rambleraptor commented on code in PR #3817:
URL: https://github.com/apache/iceberg-python/pull/3817#discussion_r3832765266
##########
pyiceberg/expressions/visitors.py:
##########
@@ -1880,25 +1880,29 @@ def visit_not_nan(self, term: BoundTerm) ->
BooleanExpression:
return self.visit_true()
def visit_less_than(self, term: BoundTerm, literal: LiteralValue) ->
BooleanExpression:
- if term.eval(self.struct) < literal.value:
+ value = term.eval(self.struct)
+ if value is None or value < literal.value:
Review Comment:
This seems like another issue where AlwaysFalse and AlwaysTrue both evaluate
to True.
I'm happy to create a small helper method that we can use in these situations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
