kevinjqliu commented on code in PR #3689:
URL: https://github.com/apache/iceberg-python/pull/3689#discussion_r3832240486
##########
tests/expressions/test_residual_evaluator.py:
##########
@@ -211,6 +211,9 @@ def test_is_not_nan() -> None:
res_eval = residual_evaluator_of(spec=spec, expr=predicate,
case_sensitive=True, schema=schema)
residual = res_eval.residual_for(Record(None))
+ assert residual == AlwaysTrue()
+
+ residual = res_eval.residual_for(Record(float("nan")))
Review Comment:
None is now true.
NaN is now false.
##########
pyiceberg/expressions/visitors.py:
##########
@@ -1852,10 +1852,10 @@ def visit_is_nan(self, term: BoundTerm) ->
BooleanExpression:
def visit_not_nan(self, term: BoundTerm) -> BooleanExpression:
val = term.eval(self.struct)
- if isinstance(val, SupportsFloat) and not math.isnan(val):
- return self.visit_true()
- else:
+ if isinstance(val, SupportsFloat) and math.isnan(val):
return self.visit_false()
+ else:
+ return self.visit_true()
Review Comment:
👍
previously for `None`, `isinstance(None, SupportsFloat)` is false, so it
returned `AlwaysFalse()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
