dramaticlly commented on PR #17745: URL: https://github.com/apache/iceberg/pull/17745#issuecomment-5376024137
thanks @dkranchii for the contribution, but I think the new test `testReachableCleanupWithDeleteManifestFromRemovedBranch` added still pass without the change in ManifestFiles. Upon further digging, I think the root cause is actually elsewhere and I opened #17763 for the fix. To be clear, the delete manifests seem to be GCed collectedly during snapshot expiration as existing test https://github.com/apache/iceberg/blob/7f879b11366e17a676a03f15247a821751415529/core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java#L1040-L1094. But the implementation might need to update. Also, I believe it would be great to expand the TestRemoveSnapshots coverage for v3 table as well, if you are willing to help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
