lishuxu commented on code in PR #867:
URL: https://github.com/apache/iceberg-cpp/pull/867#discussion_r3834874404
##########
src/iceberg/catalog/rest/auth/auth_manager.cc:
##########
@@ -148,15 +158,109 @@ class OAuth2Manager : public AuthManager {
config.optional_oauth_params(), client);
}
- return AuthSession::MakeDefault({});
+ return MakeSession(AccessTokenResponse(""), config,
/*keep_refreshed=*/false);
+ }
+
+ Result<std::shared_ptr<AuthSession>> ContextualSession(
+ const SessionContext& context, std::shared_ptr<AuthSession> parent)
override {
+ return MaybeCreateChildSession(context.credentials,
/*allow_credential=*/true,
Review Comment:
Agreed. This is part of the session lifecycle limitation.
This patch only supports initial child-session creation. Session caching and
child-session refresh will be implemented in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
