badalprasadsingh commented on code in PR #1856:
URL: https://github.com/apache/iceberg-go/pull/1856#discussion_r3838662616
##########
table/snapshot_producers.go:
##########
@@ -1002,7 +1013,12 @@ func (sp *snapshotProducer) writeAddedManifest(content
iceberg.ManifestContent,
}
func (sp *snapshotProducer) writeAddedDeleteManifest(specID int, additions
[]deleteFileAddition) (_ iceberg.ManifestFile, retErr error) {
- wr, path, counter, out, err := sp.newManifestWriter(sp.spec(specID),
iceberg.WithManifestWriterContent(iceberg.ManifestContentDeletes))
+ spec, err := sp.spec(specID)
Review Comment:
Done.
Spec ids, now, preflighted before any writer is created. So, nothing is
written. Added no-orphan tests. Also, preflighted the tombstone path and made
its group _order deterministic_, so the orphan test is not flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
