xanderbailey commented on code in PR #3059:
URL: https://github.com/apache/iceberg-rust/pull/3059#discussion_r3841892906
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -223,22 +234,6 @@ impl<'a> TableScanBuilder<'a> {
let schema = snapshot.schema(self.table.metadata())?;
- // Check that all column names exist in the schema (skip reserved
columns).
- if let Some(column_names) = self.column_names.as_ref() {
- for column_name in column_names {
- // Skip reserved columns that don't exist in the schema
- if is_metadata_column_name(column_name) {
- continue;
- }
- if schema.field_by_name(column_name).is_none() {
- return Err(Error::new(
- ErrorKind::DataInvalid,
- format!("Column {column_name} not found in table.
Schema: {schema}"),
- ));
- }
- }
- }
Review Comment:
My reading is that this was duplicative of the test below so it can be
removed altogether.
https://github.com/apache/iceberg-rust/pull/3059/changes#diff-0418b823cf97830b1ccd3a3795e670b6e8f9aaf5e37f9093af96714e72dd8ac1R247-R252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
