Revanth14 commented on code in PR #1871:
URL: https://github.com/apache/iceberg-go/pull/1871#discussion_r3860326318
##########
table/snapshots.go:
##########
@@ -272,9 +272,27 @@ type Snapshot struct {
func (s *Snapshot) UnmarshalJSON(data []byte) error {
type Alias Snapshot
var next Alias
- if err := json.Unmarshal(data, &next); err != nil {
+ // snapshot-id and timestamp-ms are required by the spec for every
format
+ // version. Decode them through pointers so an absent or null field
stays
+ // distinguishable from an explicit zero, which would otherwise be
accepted
+ // as a valid identity or as the Unix epoch.
+ aux := struct {
+ SnapshotID *int64 `json:"snapshot-id"`
+ TimestampMs *int64 `json:"timestamp-ms"`
Review Comment:
Thanks, you’re right that `SnapshotLogEntry` and `MetadataLogEntry` have
analogous required-field validation gaps. Since #1869 is specifically scoped to
`Snapshot.snapshot-id` and `timestamp-ms`, I’d prefer to track those separately
in a follow-up issue.
For manifest locations, v1 snapshots may use `manifests`, while newer
snapshots normally use `manifest-list`. Although `Snapshot.UnmarshalJSON` does
not know the table format version, it can still require at least one of those
representations to be present. Format-version-specific enforcement would need
to remain at the metadata level to preserve compatibility with legacy snapshots
in upgraded tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
