pvary commented on code in PR #17878:
URL: https://github.com/apache/iceberg/pull/17878#discussion_r3912219151
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -228,6 +257,21 @@ public Optional<Integer> getParallelism() {
};
}
+ @Override
+ public TableStats reportStatistics() {
+ try {
+ boolean columnStatsEnabled =
+
readableConfig.get(FlinkConfigOptions.TABLE_EXEC_ICEBERG_REPORT_COLUMN_STATISTICS);
+ Table loadedTable = table();
+ FlinkReadConf readConf = new FlinkReadConf(loadedTable, properties,
readableConfig);
+ return FlinkTableStatistics.reportStatistics(
Review Comment:
Is it acceptable for Flink if these statistics are approximate rather than
exact? Iceberg column statistics do not account for delete files and may also
be null, so they cannot be treated as a definitive source of truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
