adutra commented on code in PR #15989:
URL: https://github.com/apache/iceberg/pull/15989#discussion_r3915969537
##########
core/src/test/java/org/apache/iceberg/rest/TestResourcePaths.java:
##########
@@ -176,6 +193,22 @@ public void
testNamespacePropertiesWithMultipartNamespace() {
assertThat(withoutPrefix.namespaceProperties(ns)).isEqualTo("v1/namespaces/n%1Fs/properties");
}
+ @Test
Review Comment:
I just imported these tests from @aboueleyes PR. I think the whole test
class could be reduced by 60% at least if we adopt parameterized tests instead
of the tests we have today. However I would do that as a follow-up task. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
