singhpk234 commented on code in PR #15895: URL: https://github.com/apache/iceberg/pull/15895#discussion_r3916235883
########## api/src/main/java/org/apache/iceberg/catalog/SupportsContextualLoad.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.catalog; + +import org.apache.iceberg.Table; +import org.apache.iceberg.view.View; + +/** + * An optional catalog capability for loading tables and views with additional context. + * + * <p>When a table or view is loaded as part of resolving a view definition, the chain of + * referencing views and other contextual information can be passed to the catalog. This enables + * catalog servers to make authorization, credential-scoping, and auditing decisions. + * + * <p>Catalogs that do not need this context are not required to implement this interface. + */ +public interface SupportsContextualLoad { Review Comment: The mixin was just there to group catalog (table api) and viewCatalog (view api) for contextual load, and this is a new functionality entirely. Other angle is spark also needs a mixin and in that case TableCatalog and ViewCatalog are in spark so we need a spark specific _**mixin**_ since we can't modify them. i can put them to catalog / viewCatalog if we want to reuse existing api and open to modifying this with default fail which we have been doing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
