singhpk234 commented on code in PR #17920:
URL: https://github.com/apache/iceberg/pull/17920#discussion_r3910275317


##########
docs/docs/catalog-properties.md:
##########
@@ -94,6 +94,12 @@ Required and optional properties to include while using 
`oauth2` authentication
 | `audience`              | null              | Optional param to specify 
token `audience`                                                                
                                                            |
 | `resource`              | null              | Optional param to specify 
`resource`                                                                      
                                                            |
 
+!!! warning
+    `credential` and `token` are secrets. Engines may expose catalog 
configuration in their UIs and logs —
+    Spark, for example, lists it in the Environment tab and writes it to event 
logs. Confirm that your engine

Review Comment:
   ```suggestion
       Apache Spark, for example, lists it in the Environment tab and writes it 
to event logs. Confirm that your engine
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to