fallintoplace opened a new pull request, #1990: URL: https://github.com/apache/iceberg-go/pull/1990
## Summary - **Avoid the second recursive schema clone** after `Schema.Fields()` already returns deep defensive copies. - **Keep `IdentifierFieldIDs` cloned** so the returned schema stays isolated. - Add a nested schema regression test and benchmark with mutable defaults. ## Testing - `go test ./table ./view` - `go test -race ./table ./view` - `go vet ./table ./view` ## Benchmark `BenchmarkCloneSchemaWithNestedDefaults` improved from about 3.0-3.8 us/op, 4320 B/op, 63 allocs/op to 1.82-1.84 us/op, 2696 B/op, 38 allocs/op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
