nssalian commented on code in PR #17726:
URL: https://github.com/apache/iceberg/pull/17726#discussion_r3938114617
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -581,7 +582,9 @@ protected Variant convertVariantValue(Object value) {
}
List<String> sortedFieldNames =
-
collectFieldNames(value).stream().sorted().collect(Collectors.toList());
+ collectFieldNames(value).stream()
+ .sorted(Comparators.charSequences())
Review Comment:
Added supplementary-char coverage at both:
TestRecordConverter.testConvertVariantValueOrdersFieldNamesByUtf8 (a
convertVariantValue map keyed by U+FFFF and U+10000, asserting the UTF-8
metadata order and the field values) and
TestVariantMetrics.testShreddedObjectBoundFieldsOrderedByUtf8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
