amogh-jahagirdar commented on code in PR #17960:
URL: https://github.com/apache/iceberg/pull/17960#discussion_r3938409086
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -118,7 +118,12 @@ public static void validate(Map<String, String> props,
Schema schema) {
* @return a metrics config for the given table
*/
public static MetricsConfig forTable(Table table) {
Review Comment:
This is the only called method for passing through to writers as far as I
can tell. Technically writers can always choose to write with any partition
spec, but I don't see it in the code base so I didn't bother adding a
`from(props, schema, partitionSpec, SortOrder)` schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
