moomindani commented on PR #17179: URL: https://github.com/apache/iceberg/pull/17179#issuecomment-5562126732
@CTTY this is the companion to #17177 and independent of it — separate branch, no shared commits, reviewable on its own and in either order. `s3.checksum-algorithm` selects the algorithm the SDK uses for upload integrity protection, applied per request in `S3OutputStream` for PutObject, CreateMultipartUpload and UploadPart. Open since 13 July, no review, CI green (44/44). There is one naming question in the PR body — `s3.checksum-algorithm`, next to the existing `s3.checksum-enabled`, versus `s3.write.checksum-algorithm`, matching `s3.write.storage-class`, since this only affects uploads. Either works for me and it is a one-line rename, so please do not let it block the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
