moomindani commented on PR #17177: URL: https://github.com/apache/iceberg/pull/17177#issuecomment-5562126340
@CTTY would you be able to review this one? You merged #16794 and #16853 in the AWS module, and this PR has had no review since it was opened on 12 July. To make it easier to say yes, I am withdrawing the design question I raised earlier in this thread. This PR leaves every AWS SDK default untouched when the new properties are unset, so there is no behavior change and `s3.request-checksum-calculation=when_required` is strictly opt-in. Whether Iceberg should flip the default for S3-compatible stores is a separate question, and I will raise it separately rather than hold this up. Why it matters: on #14439, users on Dell ECS and the GCS S3-compatible API have no in-Iceberg way out today. @patricklucas pinned the AWS SDK back to 2.29.52 in April to get PUTs working, and the only other workaround is the `AWS_REQUEST_CHECKSUM_CALCULATION` environment variable. The first commit here is @rcjverhoef's from #15391, preserved at his suggestion. Rebased onto current `main`, CI green (44/44). #17179 is independent of this PR and can be reviewed in either order. @danielcweeks to close the loop on my 22 August comment: the default question above is withdrawn from this PR, so there is nothing for you to rule on here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
