smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r3946494635
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -245,7 +311,44 @@ private boolean reconcileOnSimpleUpdate(
@Override
public FileIO io() {
- return io;
+ if (tableKeyId == null) {
+ return io;
+ }
+
+ if (encryptingFileIO == null) {
+ encryptingFileIO = EncryptingFileIO.combine(io, encryption());
+ }
+
+ return encryptingFileIO;
+ }
+
+ @Override
+ public EncryptionManager encryption() {
Review Comment:
Actually this is an issue currently, more severe than IO initialisation,
I've put up https://github.com/apache/iceberg/issues/17990 /
https://github.com/apache/iceberg/pull/17984 with some more thoughts. Thanks to
@singhpk234 for flagging!
If folks are on board, I'll wait for that to merge as it will significantly
change / simplify this PR, then I'll rebase in one go to get this PR up to date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
