Fokko commented on PR #3418: URL: https://github.com/apache/iceberg-python/pull/3418#issuecomment-5567513945
We still need to follow up on https://github.com/apache/iceberg-python/pull/3418#issuecomment-5522774352 In the current state of this PR. PyIceberg honors `client.request-timeout`, while Java listens to `client.connection-timeout-ms` and `client.socket-timeout-ms`. For context, the rest-catalog can inject these properties. Having different properties for both Java and PyIceberg would require configuring many properties. Therefore, we look at Java, as it is the reference implementation, and keep PyIceberg as close as possible to the configuration. Since requests do not allow for splitting the timeout between the socket and the request timeout, we just sum them and use that as the timeout (timeout in milliseconds, we can floor it when converting to seconds). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
