wombatu-kun commented on PR #17925: URL: https://github.com/apache/iceberg/pull/17925#issuecomment-5568626039
#17713 fixes the same eager-rebalance replay from the other side - it skips already-consumed control records in `consumeAvailable` instead of discarding the in-flight commit - and @uros-b has an open consolidation question there, since #17376 and #17450 carry a byte-equivalent guard and #17933 makes `controlTopicOffsets` monotonic. Worth stating in the description how this relates: as far as I can tell the reset is the only one of the four that also clears a coordinator's buffer after it loses its partitions, which a skip guard leaves intact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
