zhjwpku commented on code in PR #910: URL: https://github.com/apache/iceberg-cpp/pull/910#discussion_r3950613570
########## AGENTS.md: ########## @@ -28,3 +28,17 @@ When assessing potential vulnerabilities or calibrating automated security findings, use [`SECURITY-THREAT-MODEL.md`](SECURITY-THREAT-MODEL.md) as the authoritative detailed description of this repository's security boundaries, trust assumptions, and non-boundaries. + +## Build System Consistency + +Keep CMake and Meson build definitions in sync. When adding, removing, or +renaming source files, headers, tests, or build targets, or changing dependencies +or build options, update the corresponding CMake (`CMakeLists.txt` and CMake +modules) and Meson (`meson.build` and `meson.options`) definitions in the same +change. + +## PR & Commit Conventions + +- Use Conventional Commits for commit messages. +- Commit messages describe the what and why, not implementation details. +- Run `pre-commit` for every PR and fix any reported issues. Review Comment: Yeah, this is enforced by ci, but I think it would be great if the agent can run pre-commit locally before creating the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
