superdiaodiao commented on PR #17464: URL: https://github.com/apache/iceberg/pull/17464#issuecomment-5578657782
Still relevant — flagging so this does not go stale. Both of @uros-b's review comments are addressed: 7105ad0 added the `TestHiveViewCommits` coverage for the create-view path, and 639bd29 added `TestHiveCommits.testThriftExceptionUnknownStateOnCreateCommitWhenTableNeverPersisted`, which drives a failed create through the real `HiveTableOperations`. Both fail on `main` without the fix, and CI is green. For context on the duplicate: #17548 proposes the same one-line guard without tests and is now going stale too, so the underlying bug — a failed create commit reporting FAILURE instead of UNKNOWN because `checkCurrentMetadataLocation` NPEs on null metadata — is currently unfixed on `main` either way. I have also raised this on [email protected]. Happy to rebase or adjust anything if a committer has a moment to look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
