amirmor1 commented on PR #17164:
URL: https://github.com/apache/iceberg/pull/17164#issuecomment-5580024543
@manuzhang
All four of your comments are addressed:
- writeMetadata now returns the length directly, with the close scoped in
a nested try
so the post-close read is explicit (same reason PuffinWriter#finish
reads storedLength
after close). Dropped the metadataLength helper.
- Test renamed to drop the `test` prefix.
- Docs reworded to avoid the Java "null" detail.
- The size is now captured per commit attempt in SnapshotProducer,
following the existing
newSnapshotId pattern, so it's no longer read off shared ops state at
report time.
Added eachCommitReportsTheMetadataFileSizeItWrote to cover the scoping.
Still happy to thread the value through the commit path explicitly instead
if you'd prefer
that shape — just let me know. No rush, and thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
