nastra commented on code in PR #15869:
URL: https://github.com/apache/iceberg/pull/15869#discussion_r3958403450
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -259,11 +284,105 @@ public void deletePrefix(String prefix) {
}
@Override
- public void close() {
- if (vendedAdlsCredentialProvider != null) {
- vendedAdlsCredentialProvider.close();
+ public void setCredentials(List<StorageCredential> credentials) {
+ Preconditions.checkArgument(credentials != null, "Invalid storage
credentials: null");
+ // stop any refresh that might be scheduled
+ if (refreshFuture != null) {
+ refreshFuture.cancel(true);
+ }
+
+ // copy credentials into a modifiable collection for Kryo serde
+ this.storageCredentials = Lists.newArrayList(credentials);
+
+ // if the clients are already initialized, we need to allow them to be
recreated
+ synchronized (this) {
Review Comment:
I think this is missing another if (clientCache != null) { check right
before the synchronized block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
