superdiaodiao commented on PR #17464: URL: https://github.com/apache/iceberg/pull/17464#issuecomment-5588773105
All five in 0a6a783. - `View creation may not have registered metadata yet.` — right, it was copy-pasted from the table side. - Dropped the `strictStatus` / `status` wrappers; the tests call `checkCommitStatusStrict` and `checkCommitStatus` directly. - Both javadocs shortened to your one-liners. - Removed the `try`/`finally`. You are right that it is redundant — `createLocation` is a sibling of `viewLocation` under the same test root, so it goes with the rest of the temp tree. Dropping it also let `IOException` come off the method signature. ``` TestBaseMetastoreTableOperations tests=2 failures=0 TestHiveCommits tests=16 failures=0 TestHiveViewCommits tests=13 failures=0 ./gradlew spotlessCheck passed ``` Net −25 lines. Thanks for the thorough pass — the diff ended up a good deal tighter than what I opened with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
