rambleraptor commented on issue #1551: URL: https://github.com/apache/iceberg-python/issues/1551#issuecomment-5590284816
I've let this linger for a little too long. I've gone ahead and updated it. Some quick notes: - We should have a default for new tables for `next_row_id`, so I've added that - The Spark integration test is a great idea. I've added a test where Spark reads a v3 table written by PyIceberg. - I'm hesitant to add in `encryption-key` support just yet. By adding those fields, we make it look like we have any support for encryption (which we don't!). I'm happy to add it in, but I think we should have that as a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
