Copilot commented on code in PR #7: URL: https://github.com/apache/iceberg-verification/pull/7#discussion_r3961609978
########## .github/ISSUE_TEMPLATE/issue.yml: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Issue +description: Test surfaces, verification tooling, documentation, and repository governance. +body: + - type: markdown + attributes: + value: | + This repository holds cross-language conformance fixtures and the + guidelines for contributing them. + + The following two discussion topics are explicitly left out of scope of this repository: + + - What the spec requires is discussed and settled on `[email protected]`. + - A divergence in one implementation is fixed in that implementation's + repository. + + - type: dropdown + id: type Review Comment: GitHub Issue Forms reserve some field identifiers and also commonly use `type` as a conceptual label. To avoid collisions/confusion in automation that reads form fields, prefer a more specific id (e.g., `issue_type`), especially if you plan to add Actions that parse the submitted form. ########## .github/ISSUE_TEMPLATE/issue.yml: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Issue Review Comment: The template name `Issue` is very generic and can be ambiguous when a repository later adds additional templates (e.g., Bug report, Feature request). Consider renaming to something more specific to this repo’s purpose (e.g., `Conformance fixtures issue` or `Test fixtures / governance issue`) so users can more quickly choose the right entry in the template picker. ########## .github/ISSUE_TEMPLATE/issue.yml: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Issue +description: Test surfaces, verification tooling, documentation, and repository governance. +body: + - type: markdown + attributes: + value: | + This repository holds cross-language conformance fixtures and the + guidelines for contributing them. + + The following two discussion topics are explicitly left out of scope of this repository: + + - What the spec requires is discussed and settled on `[email protected]`. + - A divergence in one implementation is fixed in that implementation's + repository. + + - type: dropdown + id: type + attributes: + label: Type + description: | + - **New test surface**: a spec behavior no subdirectory covers today. + - **New cases**: further inputs and expected values under a surface that already exists. + - **Fixture correction**: a committed input, expected value, or reference table is wrong. + - **Verification tooling**: automation that runs a surface, reports divergence, or generates fixtures. + - **Consumption**: wiring this repository into an implementation's CI. + - **Documentation**: `README.md`, `CONTRIBUTING.md`, or a surface README. + - **Repository governance**: process, ownership, release, or infrastructure. + options: + - New test surface + - New cases in an existing surface + - Fixture correction + - Verification tooling + - Consumption by an implementation + - Documentation + - Repository governance + - Other + validations: + required: true + + - type: textarea + id: description Review Comment: Using `description` as a field `id` can be confusing because the Issue Form itself already has a top-level `description`. Consider renaming the field id to something like `summary` or `details` to reduce ambiguity for future maintainers and for any tooling that parses the YAML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
