Fokko commented on code in PR #3924:
URL: https://github.com/apache/iceberg-python/pull/3924#discussion_r3966131809
##########
tests/catalog/test_hive.py:
##########
@@ -293,6 +297,7 @@ def test_create_table(
catalog._client = MagicMock()
catalog._client.__enter__().create_table.return_value = None
catalog._client.__enter__().get_table.return_value = hive_table
+ catalog._client.__enter__().get_table_req.return_value =
GetTableResult(table=hive_table)
Review Comment:
More of a meta thing, but I think most of these mock tests predate the Hive
integration tests, not sure how valuable these are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
