xanderbailey commented on code in PR #2651:
URL: https://github.com/apache/iceberg-rust/pull/2651#discussion_r3968065235
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -1465,8 +1484,10 @@ impl SessionCatalog for RestSessionCatalog {
}
};
+ // The commit response carries no credentials, so build a plain FileIO;
+ // the transaction layer reuses the credentialed one it already holds.
let file_io = self
- .load_file_io(Some(&response.metadata_location), None)
+ .load_file_io(Some(&response.metadata_location), None, None)
Review Comment:
I guess in Java they have `TableOperations` which carries the FileIo rather
than having to build a new one after the update 🤔 . There are advantages to the
way our commit path works so not saying we should look to move in that
direction. Just trying to work out how we could make this more bullet-proof.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
