uros-b commented on PR #17842:
URL: https://github.com/apache/iceberg/pull/17842#issuecomment-5598165102
One remaining gap vs SparkReadConf.branch() (and v4.1 determineWriteBranch):
only the option early-returns. Identifier + session WAP still hits "Cannot
write to both branch and WAP branch". So, after this PR:
- .option("branch", "audit") + spark.wap.branch -> writes to audit
- writeTo("t.branch_audit") + spark.wap.branch -> still ValidationException
Could we use the same inputBranch = identifier != null ? identifier : option
early-return as SparkReadConf, and update TestPartitionedWritesToWapBranch the
way #15288 did on v4.1? If keeping identifier+WAP as an error is intentional,
please call that out in the PR description, right now it says identifier also
takes precedence.
A small writeTo(...).option("branch", ...) round-trip would also help; the
current tests only construct SparkWriteConf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
