sungwy commented on code in PR #17979:
URL: https://github.com/apache/iceberg/pull/17979#discussion_r3970140184
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -337,7 +337,9 @@ private <T extends RESTResponse> T handleResponse(
Consumer<Map<String, String>> responseHeaders,
ParserContext parserContext)
throws IOException {
- Map<String, String> respHeaders = Maps.newHashMap();
+ // Field names are case-insensitive (RFC 9110), and HTTP/2 requires them
to be lowercase, so
+ // callers cannot rely on a server's chosen spelling to look a header up.
Review Comment:
Could we remove the part about HTTP/2 requirement? I was a bit confused at
first because it makes it seem like we are writing for HTTP/2 conformance
IIUC we are just trying to conform with RFC 9110 rule for HTTP/1 field-name
case-insensitivity, and HTTP/2's lowercase form is just an explanation as to
why the Armeria servers emit them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
