iremcaginyurtturk commented on PR #1999: URL: https://github.com/apache/iceberg-go/pull/1999#issuecomment-5597061697
Thanks for the review — both points addressed in cca7c83: 1. **Wiring now pinned by a test.** Added `TestSigV4SignsWithPropsCredentials`, which drives a request through a test server and asserts the SigV4 `Authorization` header contains `Credential=<props access key>/`. Neutralizing the `cfg.Credentials = creds` assignment makes the test fail (falls back to the default chain → `no EC2 IMDS role found`), so the wiring is no longer deletable while green. 2. **Partial credentials now error.** `staticCredsFromProps` returns an error when only one of `s3.access-key-id` / `s3.secret-access-key` is set, instead of silently signing as the ambient identity. Neither set still returns `(nil, nil)` so the default chain is used (e.g. instance role); both set builds the static provider. Covered by the updated `TestStaticCredsFromProps`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
