rdblue commented on code in PR #18021:
URL: https://github.com/apache/iceberg/pull/18021#discussion_r3972777954
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -123,10 +132,13 @@ private void incrementSkipCount(FileContent content) {
}
private CloseableIterable<TrackedFile> open() {
+ InputFile file = ManifestFiles.newInputFile(io, manifest);
FileFormat format = FileFormat.fromFileName(file.location());
Preconditions.checkArgument(
format != null, "Cannot determine format of manifest: %s",
file.location());
+ scanMetrics.scannedDataManifests().increment();
Review Comment:
Yes, each time an iterator is created, the counter should be incremented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
