pvary commented on code in PR #16790:
URL: https://github.com/apache/iceberg/pull/16790#discussion_r3978809857
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/data/RowDataProjection.java:
##########
@@ -109,16 +113,18 @@ private static RowData.FieldGetter createFieldGetter(
switch (projectField.type().typeId()) {
case STRUCT:
RowType nestedRowType = (RowType) rowType.getTypeAt(position);
+ RowDataProjection nestedProjection =
+ RowDataProjection.create(
+ nestedRowType, rowField.type().asStructType(),
projectField.type().asStructType());
Review Comment:
This creates an unnecessary RowDataProjection object.
Shall we just create the getters here, and build the RowDataProjection in
the lambda?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
