moomindani commented on PR #3551: URL: https://github.com/apache/iceberg-python/pull/3551#issuecomment-5628136413
@rambleraptor thanks for picking this back up, and for the `next_row_id` default and the Spark read test. Deferring `encryption-key` makes sense to me — adding the fields without any encryption behind them would advertise support that does not exist. One thing that may otherwise stall the reviewers you pinged: the two red checks are infrastructure, not your code. `integration-test` never got as far as running anything — the hive image build failed while installing packages: ``` target hive: failed to solve: process "/bin/sh -c apt-get update -qq && ..." did not complete successfully: exit code: 100 make: *** [Makefile:114: test-integration-setup] Error 1 ``` Since `python-integration-required` is a required check, a push to re-trigger it would help — worth doing before @Fokko, @kevinjqliu or @geruh looks, so the red X does not read as a real failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
