huaxingao commented on code in PR #17966:
URL: https://github.com/apache/iceberg/pull/17966#discussion_r3986306772
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4964,6 +5078,41 @@ components:
metadata:
$ref: '#/components/schemas/FunctionMetadata'
+ CreateFunctionRequest:
Review Comment:
Good point. I went with the first option and documented it on `definitions`:
the server assigns `definition-id`, `current-version-id`, and each version's
`version-id` and `timestamp-ms`, replacing client-provided values.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4964,6 +5078,41 @@ components:
metadata:
$ref: '#/components/schemas/FunctionMetadata'
+ CreateFunctionRequest:
+ description: |
Review Comment:
This one is already `description: |`, which preserves newlines as written,
so it renders as two paragraphs — left as is. Fixed the plain scalars on
createFunction and dropFunction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
