gaborkaszab commented on PR #17545: URL: https://github.com/apache/iceberg/pull/17545#issuecomment-5631895976
Hi @stevenzwu @anoopj @huaxingao Thanks for the approvals! In the meantime, I double-checked the code around this PR and I found some additional usage related to `ManifestListFile`, this time in `EncryptionManager`'s encrypt path. I got rid of the urge for them and introduced more generic functions as I already did for the decrypt path. I eliminated the usage of `BaseManifestListFile` too and managed to get rid of the class. Would you mind taking another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
