findinpath commented on code in PR #17930:
URL: https://github.com/apache/iceberg/pull/17930#discussion_r3988810976
##########
core/src/main/java/org/apache/iceberg/view/ViewVersionReplace.java:
##########
@@ -80,11 +84,46 @@ ViewMetadata internalApply() {
.defaultCatalog(defaultCatalog)
.putAllSummary(EnvironmentContext.get())
.addAllRepresentations(representations)
+ .addAllRepresentations(retainedRepresentations())
Review Comment:
How do you envision that adjustments for one view dialect query happen via
SQL?
It seems to me that the current approach may allow drifting between dialects
where Spark query selects from t1 table and Trino dialect selects from t2 table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
