kevinjqliu commented on code in PR #3205:
URL: https://github.com/apache/iceberg-rust/pull/3205#discussion_r3994504428


##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -18,6 +18,22 @@
 name: Bindings Python CI
 
 on:
+  push:
+    branches:
+      - main
+    paths:

Review Comment:
   this is same paths filter that was previously removed when we enabled merge 
queue
   
   
https://github.com/apache/iceberg-rust/pull/3195/changes#diff-9537787e53d88b68b4971987a5d6af285f2b33192df721a2cdb926497b82844eL25-L37



##########
.github/workflows/ci.yml:
##########
@@ -18,6 +18,22 @@
 name: CI
 
 on:
+  push:
+    branches:
+      - main
+    paths:

Review Comment:
   this is same paths filter that was previously removed when we enabled merge 
queue
   
   
https://github.com/apache/iceberg-rust/pull/3195/changes#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL25-L37



##########
.github/workflows/public-api.yml:
##########
@@ -18,6 +18,11 @@
 name: Public API
 
 on:
+  push:
+    branches:
+      - main
+    paths:

Review Comment:
   this is same paths filter that was previously removed when we enabled merge 
queue
   
   
https://github.com/apache/iceberg-rust/pull/3195/changes#diff-dc6fd41e388078d0881061d633eba7553bd66f190fd66faa8a7488b91bc8bfc9L25-L26



##########
.github/workflows/ci.yml:
##########
@@ -18,6 +18,22 @@
 name: CI
 
 on:
+  push:
+    branches:
+      - main

Review Comment:
   main push trigger is needed to hydrate cache 
   
   
https://github.com/apache/iceberg-rust/blob/29929f6b6207dcf2ebf8e93c634adf9b7b643264/.github/workflows/ci.yml#L126



##########
.github/workflows/public-api.yml:
##########
@@ -18,6 +18,11 @@
 name: Public API
 
 on:
+  push:
+    branches:
+      - main

Review Comment:
   main push trigger is needed to hydrate cache 
   
   
https://github.com/apache/iceberg-rust/blob/29929f6b6207dcf2ebf8e93c634adf9b7b643264/.github/workflows/public-api.yml#L45



##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -18,6 +18,22 @@
 name: Bindings Python CI
 
 on:
+  push:
+    branches:
+      - main

Review Comment:
   main push trigger is needed to hydrate cache 
   
   
https://github.com/apache/iceberg-rust/blob/29929f6b6207dcf2ebf8e93c634adf9b7b643264/.github/workflows/bindings_python_ci.yml#L79



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to