Copilot commented on code in PR #3953:
URL: https://github.com/apache/iceberg-python/pull/3953#discussion_r3996964494
##########
tests/avro/test_file.py:
##########
@@ -225,7 +225,7 @@ def
test_write_manifest_entry_with_iceberg_read_with_fastavro_v2() -> None:
fa_entry = next(it)
v2_entry = todict(entry)
- for field in ("first_row_id", "referenced_data_file",
"content_offset", "content_size_in_bytes"):
+ for field in ("first_row_id", "content_offset",
"content_size_in_bytes"):
Review Comment:
This only verifies the new field when its value is `None`. A non-null case
is essential here: the `AvroOutputFile` above omits `record_schema`, so its
positional V2 writer reads slot 16 (`first_row_id`) from the default V3
`DataFile`, while `referenced_data_file` is slot 17; the actual reference would
be written as null. Set a non-null reference and either pass the V3 record
schema or exercise `write_manifest`, then assert it round-trips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
