pvary commented on code in PR #18027:
URL: https://github.com/apache/iceberg/pull/18027#discussion_r4015725518
##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchUtil.java:
##########
@@ -64,6 +65,13 @@ public static Pair<int[], Integer> buildRowIdMapping(
}
PositionDeleteIndex deletedPositions = deletes.deletedRowPositions();
+
+ // positions in a batch form a contiguous ascending range, so the index
can be traversed once
+ // for the whole range instead of being probed once per row
+ if (deletedPositions != null && !deletes.hasEqDeletes()) {
Review Comment:
Do we want to short circuit the `no-deletes` case as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
