danielcweeks commented on PR #18045: URL: https://github.com/apache/iceberg/pull/18045#issuecomment-5694633921
> the changes themselves LGTM but the one concern I have is that we're now adding a REST-specific concept (Labels, FieldLabel) outside of the `org.apache.iceberg.rest` package, meaning that those things become part of the public API immediately. @danielcweeks any thoughts on that? @nastra this actually isn't REST-specific. For example, you can implement catalog labels with any catalog implementation (e.g. BigLake Catalog). While we expose this with REST, pretty much any implementation can support labels, so I think the packaging is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
