rambleraptor commented on code in PR #3384:
URL: https://github.com/apache/iceberg-python/pull/3384#discussion_r4028483209
##########
tests/table/test_upsert.py:
##########
@@ -927,3 +950,222 @@ def test_upsert_snapshot_properties(catalog: Catalog) ->
None:
for snapshot in snapshots[initial_snapshot_count:]:
assert snapshot.summary is not None
assert snapshot.summary.additional_properties.get("test_prop") ==
"test_value"
+
+
+_UUID_BYTES = uuid.uuid4().bytes
+_STRUCT = pa.struct([("a", pa.int32())])
+_MAP = pa.map_(pa.string(), pa.int32())
+
+
[email protected](
+ "table_type, source_key, expected_error, match",
+ [
Review Comment:
This is a personal preference, but I think the test parameterization makes
the tests messy. Some ideas:
- A helper method and then calling that helper method multiple times.
- Comments for the parameters to help make it more obvious what some of
these tests are doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
