flyrain commented on code in PR #18057:
URL: https://github.com/apache/iceberg/pull/18057#discussion_r4029227814
##########
format/udf-spec.md:
##########
@@ -118,19 +122,26 @@ following fields required. Any other fields must be
ignored.
e.g., `{ "type": "struct", "fields": [ { "name": "id", "type": "int" }, {
"name": "name", "type": "string" } ] }`
#### Definition ID
-The `definition-id` is a canonical string derived from the parameter types,
formatted as a comma-separated list with no
-spaces. Each type uses the following string representation:
+The `definition-id` is a canonical string derived from the parameter types,
formatted as a comma-separated list. The
Review Comment:
It should be fine as long as there are no name conflicts. Do we expect a
name conflict for the GEO types? For example, do we foresee two
functions,`foo(geometry(srid: 3857) g)`, and `bar(geometry(srid:3857) g)`.
Having a space in the ID string may also cause problem. We may have to
encode it if we have to keep the space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
