rdblue commented on a change in pull request #2038:
URL: https://github.com/apache/iceberg/pull/2038#discussion_r559050007
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergOutputCommitter.java
##########
@@ -188,7 +193,13 @@ private JobConf jobConf(Table table, int taskNum) {
conf.setNumReduceTasks(0);
conf.set(HiveConf.ConfVars.HIVEQUERYID.varname, QUERY_ID);
- HiveIcebergStorageHandler.put(conf, table);
+ Map<String, String> propMap = new HashMap<>();
Review comment:
Is this needed because a value may be `null`? If not, we prefer to use
`Maps.newHashMap` that enforces non-null keys and values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
