flyrain commented on pull request #2479:
URL: https://github.com/apache/iceberg/pull/2479#issuecomment-821920661


   > @flyrain, how long has this been a problem? Do we need to fix master or 
are the 0.11.x releases also affected?
   
   Hi @rdblue , you got that right. It is problem when we were integrating 
Parquet 1.12 with Iceberg internally, specifically, Parquet Modular 
encryption(PME) uses the runtime libs of `org.codehaus.jackson`. With the 
current shading we have in Iceberg, it reported class not found.
   
   Both the master branch and 0.11.x releases are OK since they use parquet 
1.11 now. But the community is trying to use Parquet 1.12 to enable PME. So I 
suggest to fix it in master, and leave 0.11.x alone. We probably won't enable 
PME in 0.11.x.
   
   Besides, even without Parquet 1.12 integration, this shading is unnecessary 
since it shades a non-exist package 
`org.apache.parquet.shaded.org.codehaus.jackson`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to