RussellSpitzer commented on a change in pull request #2591:
URL: https://github.com/apache/iceberg/pull/2591#discussion_r632576049
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteStrategy.java
##########
@@ -71,8 +71,9 @@
* Method which will rewrite files based on this particular
RewriteStrategy's algorithm.
* This will most likely be Action framework specific (Spark/Presto/Flink
....).
*
+ * @param setId an identifier for this set of files
* @param filesToRewrite a group of files to be rewritten together
* @return a list of newly written files
*/
- List<DataFile> rewriteFiles(List<FileScanTask> filesToRewrite);
+ Set<DataFile> rewriteFiles(String setId, List<FileScanTask> filesToRewrite);
Review comment:
swapping everything to groupID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
