rdblue commented on a change in pull request #2551:
URL: https://github.com/apache/iceberg/pull/2551#discussion_r633721650



##########
File path: 
parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java
##########
@@ -140,6 +152,7 @@ public void createInputFile() throws IOException {
     OutputFile outFile = Files.localOutput(parquetFile);
     try (FileAppender<Record> appender = Parquet.write(outFile)
         .schema(FILE_SCHEMA)
+        .withWriterVersion(WriterVersion.PARQUET_2_0) // V2 is needed to force 
dictionary encoding for FIXED type

Review comment:
       @pvary, I'm assuming that people mostly don't use Parquet v2 because it 
was never finalized (to my knowledge). I think there's an ongoing effort in the 
Parquet community to clean up some of the docs, but I've not seen a vote to 
adopt any of the v2 encodings as official.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to