flyrain commented on a change in pull request #2520:
URL: https://github.com/apache/iceberg/pull/2520#discussion_r643564170
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFiles.java
##########
@@ -97,20 +141,30 @@ private ManifestFiles() {
* @param outputFile the destination file location
* @return a manifest writer
*/
- public static ManifestWriter<DataFile> write(PartitionSpec spec, OutputFile
outputFile) {
+ public static ManifestWriter<DataFile> write(PartitionSpec spec,
EncryptedOutputFile outputFile) {
return write(1, spec, outputFile, null);
}
/**
- * Create a new {@link ManifestWriter} for the given format version.
+ * @deprecated please use {@link #write(int, PartitionSpec,
EncryptedOutputFile, Long)}
+ */
+ @Deprecated
+ public static ManifestWriter<DataFile> write(int formatVersion,
PartitionSpec spec, OutputFile outputFile,
+ Long snapshotId) {
+ return write(formatVersion, spec,
EncryptedFiles.encryptedOutput(outputFile,
+ EncryptionKeyMetadata.EMPTY), snapshotId);
Review comment:
A nit: 4 spaces indentation rather than 8 spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
