SreeramGarlapati commented on pull request #2660: URL: https://github.com/apache/iceberg/pull/2660#issuecomment-854385721
> As incremental read i understand why as a first implementation you do not support OVERWRITES snapshot. But as incremental read implementation, REPLACE or DELETES should just be ignored and not propagated ? @tprelle - your suggestion totally makessense. I am definitely planning to implementing `ignore deletes` & `replace`. I will introduce a spark option for it in my next PR. Pl. refer to our disc here: https://github.com/apache/iceberg/pull/2611#issuecomment-852783552. Overall, the principle that I am trying to follow - which also came as a suggestion from @rdblue - is that - we want to keep the PRs as small and yet useful as possible - to keep the cognitive load on the reviewers minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
