nastra commented on a change in pull request #2664:
URL: https://github.com/apache/iceberg/pull/2664#discussion_r646407274
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -80,12 +79,14 @@
private UpdateableReference reference;
private String name;
private FileIO fileIO;
+ private Map<String, String> catalogOptions;
public NessieCatalog() {
}
@Override
public void initialize(String inputName, Map<String, String> options) {
+ this.catalogOptions = ImmutableMap.copyOf(options);
Review comment:
I have an integration test with Spark in
https://github.com/apache/iceberg/commit/dac4ab8b2dcb4faf4e974a0398dad0d4a4c84c82#diff-a69dddda28c4edb1f19f2f9e84de0e74a76fcf9e231b6975a72fab193b003733R146
that makes sure that the `spark.app.id` is set correctly. Unfortunately I
can't commit those changes atm, because it requires a few other changes which
are also not yet committed to `master`. Given that, it seems those options are
passed down properly to the `NessieCatalog`, unless I'm missing some logic
where those things are explicitly filtered out and not passed further down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
